Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6395 #6402

Merged
merged 5 commits into from Dec 9, 2019
Merged

Fix #6395 #6402

merged 5 commits into from Dec 9, 2019

Conversation

@piyushpalawat99
Copy link
Contributor

piyushpalawat99 commented Nov 24, 2019

This is my first pull request in this project. Please let me know if there's something that I need to fix.
PS: Created a new branch for ease of use.

@piyushpalawat99

This comment has been minimized.

Copy link
Contributor Author

piyushpalawat99 commented Nov 24, 2019

@stsewd I'm sorry to bother you but can you help me with this pr (it has not passed the Travis CI build)?

Copy link
Member

stsewd left a comment

Thanks. I left some suggestions. To fix tghe linter problme, you need to add # noqa at the end of the sentence

readthedocs/builds/constants.py Outdated Show resolved Hide resolved
readthedocs/builds/constants.py Outdated Show resolved Hide resolved
readthedocs/builds/constants.py Outdated Show resolved Hide resolved
@piyushpalawat99

This comment has been minimized.

Copy link
Contributor Author

piyushpalawat99 commented Nov 25, 2019

Thanks for guiding me through it.
Edit: It still fails the Travis CI build

readthedocs/builds/constants.py Outdated Show resolved Hide resolved
@piyushpalawat99

This comment has been minimized.

Copy link
Contributor Author

piyushpalawat99 commented Nov 25, 2019

The issue still seems to be existing. Can this be a problem on Travis' side?

@stsewd

This comment has been minimized.

Copy link
Member

stsewd commented Nov 25, 2019

@piyushpalawat99 you can check the travis log to find out the problem

builds/constants.py
Line: 114
pep8: W291 / trailing whitespace (col 24)

Or run the tests locally https://docs.readthedocs.io/en/stable/development/tests.html

@piyushpalawat99

This comment has been minimized.

Copy link
Contributor Author

piyushpalawat99 commented Nov 26, 2019

@stsewd Thanks. Done.

@stsewd
stsewd approved these changes Nov 26, 2019
@piyushpalawat99

This comment has been minimized.

Copy link
Contributor Author

piyushpalawat99 commented Nov 28, 2019

@stsewd Is there anything else that I should do to get it merged?

@piyushpalawat99

This comment has been minimized.

Copy link
Contributor Author

piyushpalawat99 commented Dec 6, 2019

@stsewd can you help me with closing this issue and merge this pull request?

@stsewd stsewd merged commit c0a876b into readthedocs:master Dec 9, 2019
2 checks passed
2 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@piyushpalawat99 piyushpalawat99 deleted the piyushpalawat99:semver-regex branch Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.