Serve non-html files from nginx (X-Accel-Redirect) #6404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the "if" that checks if we are in community or commercial and always serve the files from storage (S3 on commercial). The URL generated will have an AccessKey and Expires arguments.
|
This change will bring a possible refactor of |
ericholscher
reviewed
Nov 25, 2019
This allows us to use Content-Disposition header with the proper filename on the response (including version slug on it). Besides, on corporate, this will allow us to serve non-html files without exposing the AccessKey and/or Expires and handle this internally.
This reverts commit 3f7a9a1.
ericholscher
reviewed
Nov 25, 2019
humitos
force-pushed
the
humitos/commercial-serve-non-html-storage
branch
from
a257ce8
to
6638b43
Compare
humitos
force-pushed
the
humitos/commercial-serve-non-html-storage
branch
from
6638b43
to
540ad7f
Compare
ericholscher
reviewed
Nov 25, 2019
This looks like a good approach to me. It requires some nginx changes on .org & .com, but it will make our UX around project downloads the same across both properties, which is really nice. It will let us serve the files directly from:
- https://readthedocs.org/projects/time-test/downloads/epub/latest/
- https://readthedocs.com/projects/read-the-docs-time-test/downloads/epub/latest/
And they will have the proper time-test-latest.epub filename, which feels
…humitos/commercial-serve-non-html-storage
ericholscher
approved these changes
Nov 25, 2019
This looks good to me. We need to make sure that .com is ready for it when it gets deployed, but
humitos
changed the title
Co-Authored-By: David Fischer <david@readthedocs.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Remove the "if" that checks if we are in community or commercial and always serve the files from storage (S3 on commercial). The URL generated will have an AccessKey and Expires arguments.
EDIT: this PR also returns a response with
X-Accel-Redirectto serve the file from NGINX instead of redirecting the user to the container in BlobStorage (community). This allows us to use theContent-Dispositionheader and return the filename with the version slug on it.Related to #6326 --we can probably merge both together.