Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upServe non-html files from nginx (X-Accel-Redirect) #6404
Conversation
Remove the "if" that checks if we are in community or commercial and always serve the files from storage (S3 on commercial). The URL generated will have an AccessKey and Expires arguments.
This comment has been minimized.
This comment has been minimized.
|
This change will bring a possible refactor of |
This allows us to use Content-Disposition header with the proper filename on the response (including version slug on it). Besides, on corporate, this will allow us to serve non-html files without exposing the AccessKey and/or Expires and handle this internally.
humitos
force-pushed the
humitos/commercial-serve-non-html-storage
branch
from
a257ce8
to
6638b43
humitos
force-pushed the
humitos/commercial-serve-non-html-storage
branch
from
6638b43
to
540ad7f
|
This looks like a good approach to me. It requires some nginx changes on .org & .com, but it will make our UX around project downloads the same across both properties, which is really nice. It will let us serve the files directly from:
And they will have the proper |
|
This looks good to me. We need to make sure that .com is ready for it when it gets deployed, but |
humitos
changed the title
|
I made a small suggestion but this looks good. |
Co-Authored-By: David Fischer <david@readthedocs.org>
humitos commentedNov 25, 2019
•
edited
Remove the "if" that checks if we are in community or commercial and always serve the files from storage (S3 on commercial). The URL generated will have an AccessKey and Expires arguments.
EDIT: this PR also returns a response with
X-Accel-Redirectto serve the file from NGINX instead of redirecting the user to the container in BlobStorage (community). This allows us to use theContent-Dispositionheader and return the filename with the version slug on it.Related to #6326 --we can probably merge both together.