Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more supported field to APIv3 docs #6417

Merged
merged 1 commit into from Nov 28, 2019
Merged

Conversation

@humitos
Copy link
Member

humitos commented Nov 28, 2019

Only "Project Update" is updated. I didn't find more cases where we need to expand our docs to show all the available fields.

Closes #6385

@humitos humitos requested a review from stsewd Nov 28, 2019
@stsewd
stsewd approved these changes Nov 28, 2019
Copy link
Member

stsewd left a comment

Also, shouldn't users be able to set these at creation time?

    "analytics_code": "UA000000",
    "single_version": false,
@humitos

This comment has been minimized.

Copy link
Member Author

humitos commented Nov 28, 2019

No. APIv3 does not support that at creation time. Importing a project manually does not allow those fields either.

They may be useful for the APIv3, though. We may want to think a little more about this and consider to add them.

@humitos humitos merged commit 652e2f4 into master Nov 28, 2019
3 checks passed
3 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@humitos humitos deleted the humitos/update-apiv3-docs branch Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.