Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use trigger_build for update_repos command #6422

Merged
merged 3 commits into from Dec 3, 2019
Merged

Conversation

@humitos
Copy link
Member

humitos commented Dec 1, 2019

Use trigger_build (that will use Celery if enabled) when importing a Project (import_project_from_live) or updating documentation (update_repos) via manage commands.

Use `trigger_build` (that will use Celery if enabled) when importing a
Project (import_project_from_live) or updating
documentation (update_repos) via manage commands.
@humitos humitos requested a review from stsewd Dec 1, 2019
stsewd added 2 commits Dec 3, 2019
version.pk,
force=force,
)
else:

This comment has been minimized.

Copy link
@stsewd

stsewd Dec 3, 2019

Member

This else shouldn't be deleted.

@stsewd
stsewd approved these changes Dec 3, 2019
Copy link
Member

stsewd left a comment

Didn't find any reason to not use trigger_build 👍 . I cleaned up the imports and fix a missing else to keep the same logic. Also, I realized that we are not handling correctly INTERNAL/EXTERNAL. I'm creating a good first issue for that.

@stsewd

This comment has been minimized.

Copy link
Member

stsewd commented Dec 3, 2019

@humitos

This comment has been minimized.

Copy link
Member Author

humitos commented Dec 3, 2019

Thanks for the review and the fixes!

@humitos humitos merged commit 7ad669a into master Dec 3, 2019
3 checks passed
3 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@humitos humitos deleted the humitos/update-repos-task branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.