Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not expose env variables on external versions #6440

Merged
merged 1 commit into from Dec 5, 2019

Conversation

humitos
Copy link
Member

@humitos humitos commented Dec 5, 2019

This avoid exposing potential secrets when a PR is opened.

This avoid exposing potential secrets when a PR is opened.
@humitos humitos requested a review from ericholscher Dec 5, 2019
Copy link
Member

@ericholscher ericholscher left a comment

Makes sense -- could probably use a test if it's easy to test, just to make sure we don't break it in the future 👍

@humitos humitos merged commit 4ac8ec1 into master Dec 5, 2019
3 checks passed
@humitos humitos deleted the humitos/not-expose-env-external branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants