Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor get_downloads to make one query for default_version #6441

merged 2 commits into from Dec 5, 2019


Copy link

humitos commented Dec 5, 2019

Small refactor to avoid making multiple queries to get the default_version for each link.

@humitos humitos requested a review from stsewd Dec 5, 2019
Copy link

stsewd left a comment

Indentation is wrong, but changes are good. This could use a dict comprehension too.

stsewd approved these changes Dec 5, 2019
@stsewd stsewd merged commit 17050e1 into master Dec 5, 2019
3 checks passed
3 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
continuous-integration/travis-ci/pr The Travis CI build passed
Details No dependencies with known security vulnerabilities.
@stsewd stsewd deleted the humitos/refactor-downloads branch Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.