Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic to build internal/external versions on update_repos management command #6442

Merged
merged 4 commits into from Dec 6, 2019

Conversation

@saadmk11
Copy link
Member

saadmk11 commented Dec 5, 2019

I'm not quite sure why we have the else statement here isn't slugs a required argument here?

closes #6427

@saadmk11 saadmk11 requested a review from readthedocs/core Dec 5, 2019
@stsewd
stsewd approved these changes Dec 5, 2019
Copy link
Member

stsewd left a comment

Looks good, we can skip the all check, that's already done in the first if

I'm not quite sure why we have the else statement here isn't slugs a required argument here?

If slugs isn't given we build all docs, otherwise only the docs that have that slugs

readthedocs/core/management/commands/update_repos.py Outdated Show resolved Hide resolved
readthedocs/core/management/commands/update_repos.py Outdated Show resolved Hide resolved
saadmk11 and others added 2 commits Dec 5, 2019
Co-Authored-By: Santos Gallegos <santos_g@outlook.com>
Co-Authored-By: Santos Gallegos <santos_g@outlook.com>
@saadmk11

This comment has been minimized.

Copy link
Member Author

saadmk11 commented Dec 5, 2019

If slugs isn't given we build all docs, otherwise only the docs that have that slugs

If the slugs are not given then shouldn't we get an error?

manage.py update_repos: error: the following arguments are required: slugs

@stsewd

This comment has been minimized.

Copy link
Member

stsewd commented Dec 5, 2019

oh, good catch! That shouldn't be a required argument. Could you fix that here?

@saadmk11

This comment has been minimized.

Copy link
Member Author

saadmk11 commented Dec 5, 2019

oh, good catch! That shouldn't be a required argument. Could you fix that here?

Done! :)

@stsewd stsewd merged commit 97ed5e9 into readthedocs:master Dec 6, 2019
2 checks passed
2 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@saadmk11 saadmk11 deleted the saadmk11:version_management_command branch Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.