Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed remove_search_analytics issue #6447

Merged
merged 2 commits into from Dec 9, 2019
Merged

Conversation

@keshavvinayak01
Copy link
Contributor

keshavvinayak01 commented Dec 8, 2019

This pull request references the issue #6349.
Changes :

  • Removed SEARCH_ANALYTICS flag from feature-flags
  • Removed SEARCH_ANALYTICS property from the Feature class under project/models.py
  • Removed 'Enable search analytics' tuple from the Feature object.

Closes #6217

Copy link
Member

stsewd left a comment

Thanks, you still need to update some tests that were using the flag.

@keshavvinayak01

This comment has been minimized.

Copy link
Contributor Author

keshavvinayak01 commented Dec 9, 2019

Thanks, you still need to update some tests that were using the flag.

Cool, I'll look into it.

@stsewd
stsewd approved these changes Dec 9, 2019
Copy link
Member

stsewd left a comment

Thanks! Happy to get this issue finally closed

@stsewd stsewd merged commit f20832c into readthedocs:master Dec 9, 2019
2 checks passed
2 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
This was referenced Dec 9, 2019
Parth1811 added a commit to Parth1811/readthedocs.org that referenced this pull request Jan 9, 2020
…e template

This patch removes the check of `show_analytics` variable in
`templates/projects/project_search_analytics.html` which were expected after
fixing readthedocs#6447
Parth1811 added a commit to Parth1811/readthedocs.org that referenced this pull request Jan 9, 2020
…e template

This patch removes the check of `show_analytics` variable in
`templates/projects/project_search_analytics.html` which were expected after
fixing readthedocs#6447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.