Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Be explicit when using setup_env #6451
We want to be explicit about respecting the docker setting in all places where we do a clone (needed for #6436).
Also, it's really confusing depending on the order of calls to have
I've moved/modified the signals to be run just before the first command and send the current environment to execute over the ssh commands.
Currently when `sync_repository_task` gets triggered we use a LocalEnvironment as environment. We want to be explicit about respecting the docker setting in all places where we do a clone. Also, it's really confusing depending on the order of calls to have self.setup_env set. Wasn't able to remove it completely, we still use it outside the function that creates the environment.
Ok, triggering a build doesn't fail. All cool. I think this should be better if we use the class as it should be... Like passing all the necessary data to the constructor instead of the method and setting all the self attributes in there. But a larger refactor.