Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use django storage to build URL returned by El Proxito #6466

Merged
merged 5 commits into from Dec 18, 2019

Conversation

@humitos
Copy link
Member

humitos commented Dec 17, 2019

Isolate fixes from 6c2b187#diff-fd3394188d8793947a3ccbb4924994a1R99

With this change, we pass the full URL back to NGINX who will proxy it as is to the storage.

This fixes currently 404 in production for test-builds documentation for all versions.

@humitos humitos requested a review from readthedocs/core Dec 17, 2019
Copy link
Member

ericholscher left a comment

Makes sense after tests pass 👍

We should also remove the code that overrides this in corporate 👍

humitos added 4 commits Nov 28, 2019
This allows us to have more control on the storage class (return
always True on `.exists()`) and only mock the class when we need a
different behavior.
@humitos

This comment has been minimized.

Copy link
Member Author

humitos commented Dec 17, 2019

I brought some other commits from the other PR that fixes the tests in a good way by using a custom storage backend for tests.

@humitos humitos merged commit 9ae22cd into master Dec 18, 2019
3 checks passed
3 checks passed
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
pyup.io/safety-ci No dependencies with known security vulnerabilities.
Details
@humitos humitos deleted the humitos/use-storage-proxito branch Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.