Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "dirhtml" target #6500

Merged
merged 8 commits into from Jan 13, 2020
Merged

Added "dirhtml" target #6500

merged 8 commits into from Jan 13, 2020

Conversation

Blackcipher101
Copy link
Contributor

@Blackcipher101 Blackcipher101 commented Jan 7, 2020

fixes #6038
This fixes the issue of Sphinx make target called dirhtml but also make it conistent with RTD

Copy link
Member

@stsewd stsewd left a comment

Thanks! This is close to merge, just 2 changes needed.

docs/config-file/v2.rst Show resolved Hide resolved
readthedocs/rtd_tests/fixtures/spec/v2/schema.yml Outdated Show resolved Hide resolved
@ericholscher
Copy link
Member

ericholscher commented Jan 8, 2020

Isn't this backwards incompatible? We'd need to support both and issue a warning.

Edit: Oh, I see we're adding it, and only removing htmldir in the docs. Ignore me :)

@Blackcipher101
Copy link
Contributor Author

Blackcipher101 commented Jan 8, 2020

@stsewd I will work on it

readthedocs/rtd_tests/fixtures/spec/v2/schema.yml Outdated Show resolved Hide resolved
docs/config-file/v2.rst Outdated Show resolved Hide resolved
Co-Authored-By: Santos Gallegos <stsewd@protonmail.com>
Blackcipher101 and others added 2 commits Jan 8, 2020
Co-Authored-By: Santos Gallegos <stsewd@protonmail.com>
@Blackcipher101
Copy link
Contributor Author

Blackcipher101 commented Jan 8, 2020

@stsewd Thanks helping for out

Copy link
Member

@stsewd stsewd left a comment

Just a little changes in the rst format so tests pass.

docs/config-file/v2.rst Outdated Show resolved Hide resolved
docs/config-file/v2.rst Outdated Show resolved Hide resolved
docs/config-file/v2.rst Outdated Show resolved Hide resolved
Blackcipher101 and others added 3 commits Jan 8, 2020
Co-Authored-By: Santos Gallegos <stsewd@protonmail.com>
Co-Authored-By: Santos Gallegos <stsewd@protonmail.com>
Co-Authored-By: Santos Gallegos <stsewd@protonmail.com>
stsewd
stsewd approved these changes Jan 8, 2020
Copy link
Member

@stsewd stsewd left a comment

Looks good, thanks!

@stsewd stsewd requested a review from Jan 8, 2020
humitos
humitos approved these changes Jan 8, 2020
@stsewd stsewd merged commit b3d3ff5 into readthedocs:master Jan 13, 2020
2 checks passed
@Blackcipher101 Blackcipher101 deleted the patch1 branch Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants