New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added "dirhtml" target #6500
Merged
Merged
Added "dirhtml" target #6500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isn't this backwards incompatible? We'd need to support both and issue a warning. Edit: Oh, I see we're adding it, and only removing |
@stsewd I will work on it |
stsewd
reviewed
Jan 8, 2020
Co-Authored-By: Santos Gallegos <stsewd@protonmail.com>
stsewd
reviewed
Jan 8, 2020
Co-Authored-By: Santos Gallegos <stsewd@protonmail.com>
@stsewd Thanks helping for out |
Co-Authored-By: Santos Gallegos <stsewd@protonmail.com>
Co-Authored-By: Santos Gallegos <stsewd@protonmail.com>
Co-Authored-By: Santos Gallegos <stsewd@protonmail.com>
humitos
approved these changes
Jan 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
fixes #6038
This fixes the issue of Sphinx make target called dirhtml but also make it conistent with RTD