Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pass build to environment when doing a sync #6503

Merged
merged 2 commits into from Jan 13, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jan 8, 2020

We don't record this step, so we don't have a build

Also, added protection against None. We default project, version and build to None,
but in some parts we assume there aren't None.

We don't record this step, so we don't have a `build`
We default project, version and build to None,
but in some parts we assume there aren't None.
@ericholscher ericholscher added the PR: hotfix Pull request applied as hotfix to release label Jan 8, 2020
@ericholscher ericholscher requested a review from a team January 8, 2020 18:47
Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and is already in prod :D

@stsewd stsewd merged commit 17d5f53 into readthedocs:master Jan 13, 2020
@stsewd stsewd deleted the dont-pass-build-when-sync-repo branch January 13, 2020 15:56
stsewd added a commit to stsewd/readthedocs.org that referenced this pull request Jan 28, 2020
This is kind of the same we hit with a local env
readthedocs#6503
agjohnson pushed a commit that referenced this pull request Jan 29, 2020
* Don't assume build isn't None in a docker build env

This is kind of the same we hit with a local env
#6503

* Check for self.build

* Use context manager
agjohnson pushed a commit that referenced this pull request Jan 29, 2020
* Don't assume build isn't None in a docker build env

This is kind of the same we hit with a local env
#6503

* Check for self.build

* Use context manager
humitos pushed a commit that referenced this pull request Jan 29, 2020
This is kind of the same we hit with a local env
#6503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: hotfix Pull request applied as hotfix to release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants