Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Transifex Integration details in Internationalization page. #6531

Merged
merged 1 commit into from Jan 22, 2020

Conversation

preetmishra
Copy link
Contributor

@preetmishra preetmishra commented Jan 16, 2020

This commit changes the bad link to fabfile.py to tasks.py file in Internationalization page.

Fixes #6525.

Copy link
Member

@stsewd stsewd left a comment

Thanks, we shouldn't change the call from scripts to python code. The examples should use invoke

#. Update files and push sources (English) to Transifex:

.. prompt:: bash $
.. code-block:: python
Copy link
Member

@stsewd stsewd Jan 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be a bash call too, but using invoke


.. prompt:: bash $
.. code-block:: python
Copy link
Member

@stsewd stsewd Jan 20, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@preetmishra
Copy link
Contributor Author

@preetmishra preetmishra commented Jan 21, 2020

@stsewd Thanks for the review. I'll update the PR with the required changes.

@preetmishra
Copy link
Contributor Author

@preetmishra preetmishra commented Jan 21, 2020

@stsewd I have made the changes that were requested. It is ready for review.

Screenshot:

Screenshot from 2020-01-21 23-12-40


.. _fabric script: https://github.com/readthedocs/readthedocs.org/blob/master/fabfile.py
.. _Invoke: http://www.pyinvoke.org/
Copy link
Member

@stsewd stsewd Jan 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.. _Invoke: http://www.pyinvoke.org/
.. _Invoke: https://www.pyinvoke.org/

Copy link
Contributor Author

@preetmishra preetmishra Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change that and update the commit.

This commit changes the bad link to fabfile.py to tasks.py file in
Internationalization page.
@preetmishra
Copy link
Contributor Author

@preetmishra preetmishra commented Jan 22, 2020

@stsewd Thanks for the review. I have changed http to https.

stsewd
stsewd approved these changes Jan 22, 2020
Copy link
Member

@stsewd stsewd left a comment

Thanks!

@stsewd stsewd merged commit 0df329f into readthedocs:master Jan 22, 2020
2 checks passed
@preetmishra preetmishra deleted the docs branch Jan 22, 2020
@preetmishra
Copy link
Contributor Author

@preetmishra preetmishra commented Jan 22, 2020

Thanks, looking forward to contributing more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants