Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove .cache from parent dir #6595

Merged
merged 1 commit into from Jan 28, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jan 28, 2020

No description provided.

Copy link
Member

@humitos humitos left a comment

I'm going to add some context here.

We are caching pip packages at project level. We had discussed about caching this per-version at #5685.

This PR removes the cached packages per-project when a version is wiped which I think is a wrong relation: version removing something from project.

I'd just go for a better solution here and always use --no-cache on pip command.

@humitos
Copy link
Member

@humitos humitos commented Jan 28, 2020

We thought this issue was fixed at #6571 but we were removing the wrong directory.

Copy link
Contributor

@agjohnson agjohnson left a comment

Talked about this, and I'm +1 on this. I agree with @humitos that moving away from caching pip makes the most sense. It was added a minor speed improvement, but adds a lot of variability into the builds that shouldn't be there. Caching per version is the most technically correct if we want to cache, but the incentives aren't really there anymore -- it's just more redundant storage with not a lot of benefit

@agjohnson agjohnson merged commit 6b25a50 into readthedocs:master Jan 28, 2020
1 of 2 checks passed
@agjohnson agjohnson added the PR: hotfix label Jan 28, 2020
stsewd added a commit that referenced this issue Jan 28, 2020
@stsewd stsewd deleted the remove-cache-from-parent branch Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: hotfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants