Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update celery requirements to its latest version" #6596

Merged
merged 1 commit into from Jan 29, 2020

Conversation

agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Jan 28, 2020

This reverts commit 5939bca.

We noticed a lot of strange issues, including Celery dying without an
error, using the upgraded packages and even 4.4.0. Reverting back to
something that works for now.

This reverts commit 5939bca.

We noticed a lot of strange issues, including Celery dying without an
error, using the upgraded packages and even 4.4.0. Reverting back to
something that works for now.
@agjohnson agjohnson added the PR: hotfix label Jan 28, 2020
@agjohnson
Copy link
Contributor Author

@agjohnson agjohnson commented Jan 28, 2020

Hotfixed on relcorp only

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Jan 29, 2020

Seemed ambitious that all the issues would be fixed given how many caveats we had in the requirements file :/ Not sure how to move forward with this upgrade though.

@ericholscher ericholscher merged commit 1dd5c7a into master Jan 29, 2020
3 checks passed
@ericholscher ericholscher deleted the hotfix/revert-celery-upgrade branch Jan 29, 2020
@benjaoming
Copy link
Contributor

@benjaoming benjaoming commented Jul 22, 2020

Are there issues tracking this now?

#6448 and #4643 are closed.

@humitos
Copy link
Member

@humitos humitos commented Jul 23, 2020

No. We only have this note in the code:

# Celery 4.2 is incompatible with our code
# when ALWAYS_EAGER = True
celery==4.1.1 # pyup: ignore

We rely a lot on Celery to make Read the Docs to work. Since it's hard to test locally all the possible scenarios we usually try to upgrade Celery only when needed or try to make a deploy that only involves upgrading Celery to be able to monitor it from close.

IIRC, when we deployed the latest version, workers where randomly disconnected or they stopped consuming tasks and start doing nothing. That's why we decided to revert this change.

I'm curious, why you are interested in upgrading Celery, @benjaoming ?

@benjaoming
Copy link
Contributor

@benjaoming benjaoming commented Jul 24, 2020

@humitos I'm running Read the Docs on Python 3.7 (didn't realize it was intended for 3.6). After a lot of setup, I realized that Celery was broken (the classical async syntax keyword issue) and now I'm running it with a local patch that upgrades Celery.

I'll let you know if I experience the same hang-ups :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: hotfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants