Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't assume build isn't None in a docker build env #6599

Merged
merged 3 commits into from Jan 29, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Jan 28, 2020

This is kind of the same we hit with a local env
#6503

This is kind of the same we hit with a local env
readthedocs#6503
readthedocs/doc_builder/environments.py Outdated Show resolved Hide resolved
readthedocs/doc_builder/environments.py Outdated Show resolved Hide resolved
@stsewd stsewd force-pushed the dont-asume-build-on-docker-env branch from 2af1906 to e024beb Compare Jan 29, 2020
Copy link
Contributor

@agjohnson agjohnson left a comment

Looks good!

@agjohnson agjohnson merged commit ab234ea into readthedocs:master Jan 29, 2020
2 checks passed
agjohnson pushed a commit that referenced this issue Jan 29, 2020
* Don't assume build isn't None in a docker build env

This is kind of the same we hit with a local env
#6503

* Check for self.build

* Use context manager
@stsewd stsewd deleted the dont-asume-build-on-docker-env branch Jan 29, 2020
@humitos humitos added the PR: hotfix label Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: hotfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants