Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid infinite redirect on El Proxito on 404 #6606

Merged
merged 2 commits into from Jan 29, 2020

Conversation

humitos
Copy link
Member

@humitos humitos commented Jan 29, 2020

We need to use build_absolute_uri here because we want to compare
the full URL (including domain), but the path has to be replaced with
what's in proxito_path.

humitos added 2 commits Jan 29, 2020
We need to use `build_absolute_uri` here because we want to compare
the full URL (including domain), but the path has to be replaced with
what's in `proxito_path`.
@humitos humitos requested a review from ericholscher Jan 29, 2020
Copy link
Member

@ericholscher ericholscher left a comment

Glad to have a test for this 👍

@ericholscher ericholscher merged commit 9cb638d into master Jan 29, 2020
3 checks passed
@ericholscher ericholscher deleted the humitos/proxito-infinite-redirect branch Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants