Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for a single_version project having a version_slug for PR builds #6615

Merged
merged 5 commits into from Jan 30, 2020

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Jan 29, 2020

This fixes PR serving for single-version projects on proxito.

…uilds

This fixes PR serving for single-version projects on proxito.
@ericholscher ericholscher requested a review from humitos Jan 29, 2020
@@ -60,7 +60,8 @@ def _get_project_data_from_request(
)

# Handle single version by grabbing the default version
if final_project.single_version:
# We might have version_slug when we're serving a PR
if final_project.single_version and not version_slug:
Copy link
Member

@humitos humitos Jan 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

Copy link
Member

@humitos humitos Jan 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realize that we should add self.version_type == EXTERNAL here. It will be more explicit in the code (not just the comment) but also safer. cc @ericholscher

@ericholscher ericholscher merged commit df29789 into master Jan 30, 2020
2 of 3 checks passed
@ericholscher ericholscher deleted the fix-proxito-external-with-single-version branch Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants