Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test settings file for proxito #6623

Merged
merged 2 commits into from Feb 24, 2020
Merged

Add test settings file for proxito #6623

merged 2 commits into from Feb 24, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Feb 3, 2020

This is needed to allow us to run tests with the proxito settings in
.com (and probably in .org too)

This is needed to allow us to run tests with the proxito settings in
.com (and probably in .org too)
@stsewd stsewd requested a review from Feb 3, 2020
Copy link
Member

@humitos humitos left a comment

I think this makes sense.

We should double check that this won't break production. I don't remember exactly how is the proxito settings file generated, but I think it's based on readthedocs/settings/proxito.py which is deleted in this PR.

@stsewd
Copy link
Member Author

@stsewd stsewd commented Feb 4, 2020

@humitos looks like we are not using any file from here for the production settings, neither on .org or .com. We should use the base settings from here after it's merged so we don't duplicate them.

@stsewd stsewd requested a review from humitos Feb 11, 2020
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Feb 24, 2020

We should merge this after fixing the conflict.

@stsewd stsewd merged commit b4dcd2d into master Feb 24, 2020
3 checks passed
@stsewd stsewd deleted the stsewd/test-settings-proxito branch Feb 24, 2020
@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Feb 25, 2020

After this was merged, in my local environment it seems to create an empty readthedocs/settings/proxito.py. I think it's the result of this. This causes proxito to fail to start due to the SECRET_KEY not being set.

Edit: to be clear, the empty file is created while running inv docker.up.

@humitos
Copy link
Member

@humitos humitos commented Feb 25, 2020

Yes. This breaks the local environment. I think it's better to have everything related to tests inside the tests/ directory, so they are isolated. I propose to move this to readthedocs/proxito/tests/settings.

@humitos
Copy link
Member

@humitos humitos commented Feb 25, 2020

I open a PR with a fix for this at #6703 without changing the structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants