Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New docker release (6.0 and testing) #6654

merged 4 commits into from Feb 17, 2020


Copy link

@humitos humitos commented Feb 13, 2020

  • Update our Docker settings to support 6.0 and testing images in our YAML file.
  • Tag 5.0 as stable
  • Tag 6.0 as latest

Edit: this PR includes changes from #6653 so be careful when merging.

@humitos humitos changed the title New docker release (6.0) New docker release (6.0 and testing) Feb 13, 2020
@humitos humitos requested a review from ericholscher Feb 13, 2020
@humitos humitos marked this pull request as ready for review Feb 13, 2020
'readthedocs/build:6.0rc1': {
'python': {'supported_versions': [2, 2.7, 3, 3.5, 3.6, 3.7, 3.8, 'pypy3.5']},
'readthedocs/build:testing': {
Copy link

@ericholscher ericholscher Feb 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be labeled as 7.0, and testing used as an alias, like latest and stable. I don't think we want a specific testing image, otherwise it's done differently than all our other images.


# Alias tagged via ``docker tag`` on the build servers
'readthedocs/build:stable': DOCKER_IMAGE_SETTINGS.get('readthedocs/build:4.0'),
'readthedocs/build:latest': DOCKER_IMAGE_SETTINGS.get('readthedocs/build:5.0'),
'readthedocs/build:stable': DOCKER_IMAGE_SETTINGS.get('readthedocs/build:5.0'),
Copy link

@davidfischer davidfischer Feb 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this change everybody who was pointed at stable in their config file to use readthedocs/build:5.0 when previously they were using readthedocs/build:4.0? I'm not super familiar with the backwards compatibility of our docker images but is that what we want?

@ericholscher ericholscher force-pushed the humitos/new-docker-release branch from 224e5b0 to 1c0a502 Compare Feb 17, 2020
Copy link

@ericholscher ericholscher left a comment

Looks good 👍

@ericholscher ericholscher merged commit 50c63f7 into master Feb 17, 2020
3 checks passed
@ericholscher ericholscher deleted the humitos/new-docker-release branch Feb 17, 2020
@humitos humitos mentioned this pull request Feb 19, 2020
@cjolowicz cjolowicz mentioned this pull request Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants