Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use x-forwarded-host in local docker environment #6679

Merged
merged 1 commit into from Feb 20, 2020

Conversation

davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Feb 19, 2020

Without this change anything that called request.build_absolute_uri made a URI of the form http://web:8000/... instead of http://community.dev.readthedocs.io/....

This prevented the connected accounts (github, bitbucket, gitlab) from working correctly.

Copy link
Member

@humitos humitos left a comment

Makes sense to me. It may be other places where we need this, probably.

@davidfischer davidfischer merged commit 1d29606 into master Feb 20, 2020
3 checks passed
@davidfischer davidfischer deleted the davidfischer/use-x-forwarded-host branch Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants