Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document setting up connected accounts in dev #6681

Merged
merged 1 commit into from Apr 6, 2020

Conversation

davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Feb 19, 2020

These steps require #6679 to work correctly.

@davidfischer davidfischer requested a review from Feb 19, 2020
Copy link
Member

@humitos humitos left a comment

This is fine to me. However, I think this can be just a fixture that automatically load all our testing Social Apps for each service. That way, we avoid following a guide to setup this each time we (core developers and contributors) want to connect to a service.

@stsewd
Copy link
Member

@stsewd stsewd commented Feb 20, 2020

BTW, with the latest version of allauth (not installed in our req yet, but we will after the django update)

You can now store OAuth credentials directly in your settings.SOCIALACCOUNT_PROVIDERS settings instead of storing them in the database using a SocialApp record.

@ericholscher
Copy link
Member

@ericholscher ericholscher commented Feb 20, 2020

I'd prefer to just have this in a fixture that we can load locally. I don't think docs are the answer here, but just having them automatically setup in dev.

@davidfischer
Copy link
Contributor Author

@davidfischer davidfischer commented Feb 20, 2020

I'd prefer to just have this in a fixture that we can load locally. I don't think docs are the answer here, but just having them automatically setup in dev.

The fixture might have to be private. I'm not sure I 100% understand the implications of sharing the secret with the world. I'll have to think about it.

@stale
Copy link

@stale stale bot commented Apr 5, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale label Apr 5, 2020
@humitos
Copy link
Member

@humitos humitos commented Apr 6, 2020

@davidfischer I think we should merge this. It's already approved and I think it's useful as it is. We could create a fixture later if we decide that's better/secure. In the meanwhile, we can have this docs up.

@stale stale bot removed the Status: stale label Apr 6, 2020
@ericholscher ericholscher merged commit 3d35386 into master Apr 6, 2020
2 checks passed
@ericholscher ericholscher deleted the davidfischer/connected-accounts-dev branch Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants