Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flag to just completely skip sync and symlink operations #6689

Merged
merged 2 commits into from Mar 3, 2020

Conversation

agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Feb 21, 2020

We can control this on a per-project basis. Once we remove symlinking
and Syncers, this can go away entirely.

We can control this on a per-project basis. Once we remove symlinking
and Syncers, this can go away entirely.
@agjohnson
Copy link
Contributor Author

@agjohnson agjohnson commented Feb 21, 2020

I'm not confident I protected all of the sync/symlink calls. I didn't put the same logic in the actual tasks as we shouldn't fire off thousands of tasks that are effectively noop tasks. This did save the webs from being hammered with thousands of symlink tasks for the project however.

@agjohnson agjohnson added the PR: work in progress label Feb 21, 2020
@davidfischer
Copy link
Contributor

@davidfischer davidfischer commented Feb 21, 2020

This worked for me in my testing to stop symlinking versions for specific projects. This didn't protect the symlink_subproject function but those subprojects would technically be different projects and could be feature flagged themselves. 👍

@@ -1505,6 +1505,7 @@ def add_features(sender, **kwargs):
UPDATE_CONDA_STARTUP = 'update_conda_startup'
CONDA_APPEND_CORE_REQUIREMENTS = 'conda_append_core_requirements'
ALL_VERSIONS_IN_HTML_CONTEXT = 'all_versions_in_html_context'
SKIP_SYNC = 'skip_sync'
Copy link
Member

@humitos humitos Feb 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I would call it SKYP_WEB_SERVERS_SYNC to make it explicit.

@humitos
Copy link
Member

@humitos humitos commented Feb 24, 2020

I don't think it worth the effort, but we could enable this Feature flag automatically on Project.save when we detect that skip = True and remove it otherwise.

@humitos humitos added the PR: hotfix label Feb 24, 2020
@agjohnson agjohnson marked this pull request as ready for review Feb 24, 2020
@agjohnson agjohnson removed the PR: work in progress label Mar 3, 2020
@agjohnson agjohnson merged commit 5fe5d0a into master Mar 3, 2020
3 checks passed
@agjohnson agjohnson deleted the agj/add-sync-skip branch Mar 3, 2020
ericholscher added a commit that referenced this issue Mar 14, 2020
ericholscher added a commit that referenced this issue Mar 17, 2020
Revert "Add feature flag to just completely skip sync and symlink operations (#6689)"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: hotfix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants