Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip promoting new stable if current stable is not machine=True #6695

Merged
merged 6 commits into from Jun 22, 2020

Conversation

humitos
Copy link
Member

@humitos humitos commented Feb 24, 2020

When the "stable" is managed by the user (because they have a
origin/stable branch, for example) we do not need to calculate which
would be the version to be promoted as stable.

So, we return immediately (without doing any computation) if the
current stable is not managed by Read the Docs.

When the "stable" is managed by the user (because they have a
`origin/stable` branch, for example) we do not need to calculate which
would be the version to be promoted as stable.

So, we return immediately (without doing any computation) if the
current stable is not managed by Read the Docs.
@humitos humitos requested a review from a team Feb 24, 2020
@humitos humitos added the Needed: tests label Mar 2, 2020
@stale
Copy link

stale bot commented Apr 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale label Apr 9, 2020
@humitos humitos added Accepted and removed Status: stale labels Apr 9, 2020
@humitos
Copy link
Member Author

humitos commented Apr 9, 2020

This is valid. I just need to write some tests for it.

@ericholscher
Copy link
Member

ericholscher commented Jun 12, 2020

@humitos would be useful to get the tests fixed up here, so we can ship it 👍

@humitos humitos removed the Needed: tests label Jun 16, 2020
@humitos humitos merged commit 03541e2 into master Jun 22, 2020
2 checks passed
@humitos humitos deleted the humitos/skip-stable-if-not-machine branch Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants