Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only output debug logging from RTD app #6717

Merged
merged 2 commits into from Apr 16, 2020
Merged

Only output debug logging from RTD app #6717

merged 2 commits into from Apr 16, 2020

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Feb 27, 2020

In normal settings only log INFO and above,
but in dev we should log DEBUG to console.
This should only output RTD debug messages though,
because others are only logging INFO and above via the logger.

In normal settings only log INFO and above,
but in dev we should log DEBUG to console.
This should only output RTD debug messages though,
because others are only logging INFO and above via the logger.
@ericholscher ericholscher requested a review from Feb 27, 2020
Copy link
Member

@humitos humitos left a comment

I'm not sure what changed (maybe a Django2 thing?) that this started being an issue now.

Change looks good to me, just asking if the DEBUG log level still works. We may want to just kill it, otherwise. I'm not sure if we are really using it though.

# Always send from the root, handlers can filter levels
'level': 'DEBUG',
'level': 'INFO',
Copy link
Member

@humitos humitos Feb 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the root logger filters by INFO, can we set DEBUG level in the handler later? With this change, is DEBUG logging under debug.log file still working?

Copy link
Member Author

@ericholscher ericholscher Mar 31, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to be able to log DEBUG messages, but only from our application. So we want DEBUG to be output, but only sent via the RTD app, not all libraries.

@ericholscher ericholscher merged commit 09c6450 into master Apr 16, 2020
2 of 3 checks passed
@ericholscher ericholscher deleted the better-logging branch Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants