Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't fail a build on api timing out #6719

Merged
merged 3 commits into from Mar 2, 2020
Merged

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Feb 27, 2020

Injecting versions on the sphinx context isn't that crucial,
since we use the footer_api to get them.

ref #6712 (comment)

Injecting versions on the sphinx context isn't that crucial,
since we use the footer_api to get them.
if v.privacy_level == PUBLIC
]
downloads = api.version(self.version.pk).get()['downloads']
except Timeout:
Copy link
Member Author

@stsewd stsewd Feb 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also, just catch all requests related errors

Copy link
Member

@ericholscher ericholscher left a comment

Makes sense to me. Definitely don't want to fail builds on this.

readthedocs/doc_builder/backends/sphinx.py Outdated Show resolved Hide resolved
Co-Authored-By: Eric Holscher <25510+ericholscher@users.noreply.github.com>
humitos
humitos approved these changes Mar 1, 2020
Copy link
Member

@humitos humitos left a comment

This is good.

A more general question, what is useful for to inject version in a static way if we are going to replace them via an AJAX call anyways?

@stsewd
Copy link
Member Author

@stsewd stsewd commented Mar 2, 2020

A more general question, what is useful for to inject version in a static way if we are going to replace them via an AJAX call anyways?

This was already discussed in slack. I have updated my comment in #6712 (comment)

@stsewd
Copy link
Member Author

@stsewd stsewd commented Mar 2, 2020

Travis is passing, rtd is stuck

@stsewd stsewd merged commit c22752d into master Mar 2, 2020
2 of 3 checks passed
@stsewd stsewd deleted the dont-fail-builds-on-api-timeout branch Mar 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants