Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flag for branch & tag syncing to API. #6729

Merged
merged 7 commits into from Mar 3, 2020

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Mar 2, 2020

This helps us lower load on specific projects that have a lot of these and aren’t using them.

ericholscher added 3 commits Mar 2, 2020
This helps us lower load on specific projects that have a lot of these and aren’t using them.
@ericholscher ericholscher requested a review from Mar 2, 2020
@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Mar 2, 2020

I've tested this locally, and I've confirmed it deletes the existing Versions associated with the tags and branches. This should help performance a lot 👍

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Mar 3, 2020

This conflicts a little with the hotfix feature flag PR to skip symlinking and sync operations. I've merged that PR so this can be resolved.

Copy link
Contributor

@agjohnson agjohnson left a comment

Changes look good!

@ericholscher ericholscher merged commit 2dca3d7 into master Mar 3, 2020
2 of 3 checks passed
@ericholscher ericholscher deleted the feature-flag-tag-branch-sync branch Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants