Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TOS PDF output #6739

Merged
merged 1 commit into from Mar 9, 2020
Merged

Add TOS PDF output #6739

merged 1 commit into from Mar 9, 2020

Conversation

agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Mar 4, 2020

Unfortunately, RTD doesn't support this output because it's a secondary
file. You have to generate this file locally, and you have to also
disable -W option, as there are warnings that fail the build,
unrelated to this change.

Unfortunately, RTD doesn't support this output because it's a secondary
file. You have to generate this file locally, and you have to also
disable `-W` option, as there are warnings that fail the build,
unrelated to this change.
@humitos
Copy link
Member

@humitos humitos commented Mar 4, 2020

You have to generate this file locally, and you have to also disable -W option, as there are warnings that fail the build, unrelated to this change.

We can add a comment about this above the latex documents config, or we can even create a new Makefile entry to generate only this file that already include the -W argument.

humitos
humitos approved these changes Mar 4, 2020
@ericholscher ericholscher merged commit 8ef6e4a into master Mar 9, 2020
3 checks passed
@ericholscher ericholscher deleted the agj/docs-tos-pdf branch Mar 9, 2020
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Mar 9, 2020

We could certainly add support for building/syncing these files, but linking them directly from our dashboard is a bit tricky, but I'd be 👍 with building in basic support for it at least.

ericholscher added a commit that referenced this issue Mar 9, 2020
This reverts commit 8ef6e4a, reversing
changes made to 9d44e5c.
ericholscher added a commit that referenced this issue Mar 9, 2020
Revert "Merge pull request #6739 from readthedocs/agj/docs-tos-pdf"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants