Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not reset the build start time when running build env #6794

Merged
merged 1 commit into from Mar 20, 2020

Conversation

humitos
Copy link
Member

@humitos humitos commented Mar 19, 2020

We are creating one Setup Environment and another Build Environment.
Once each of them is created they define the start_time which is UTC
now. Then they use the start_time to calculate the length of the
build each time the build object is updated via the API.

Since the Build Environment calls again UTC now, we override the old
start_time and we loose track of the timing for the Setup
Environment (close repository, among others).

This commit saves the original start_time and passes it to the Build
Environment so it continues calculating the difference for the
length considering the Setup Environment times as well.

Related to #6793

We are creating one Setup Environment and another Build Environment.
Once each of them is created they define the `start_time` which is UTC
now. Then they use the `start_time` to calculate the `length` of the
build each time the build object is updated via the API.

Since the Build Environment calls again UTC now, we override the old
`start_time` and we loose track of the timing for the Setup
Environment (close repository, among others).

This commit saves the original `start_time` and passes it to the Build
Environment so it continues calculating the difference for the
`length` considering the Setup Environment times as well.
@humitos humitos requested review from stsewd and Mar 19, 2020
stsewd
stsewd approved these changes Mar 19, 2020
@humitos humitos merged commit 784f534 into master Mar 20, 2020
3 checks passed
@humitos humitos deleted the humitos/start-time-from-beginning branch Mar 20, 2020
humitos added a commit that referenced this issue Mar 23, 2020
…inning

Do not reset the build start time when running build env
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants