Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check 404 page once when slug and default_version is the same #6796

Merged
merged 1 commit into from Mar 20, 2020

Conversation

humitos
Copy link
Member

@humitos humitos commented Mar 19, 2020

I found that when the version being accessed is the same as the default version of the project, we are checking twice for the existence of the same files.

@humitos humitos requested a review from Mar 19, 2020
stsewd
stsewd approved these changes Mar 19, 2020
Copy link
Member

@stsewd stsewd left a comment

I just hit this while writing some tests

@humitos humitos merged commit b5bb99c into master Mar 20, 2020
3 checks passed
@humitos humitos deleted the humitos/check-404-same-version branch Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants