Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use storage.open API correctly for tar files (build cached envs) #6799

Merged
merged 1 commit into from Mar 23, 2020

Conversation

humitos
Copy link
Member

@humitos humitos commented Mar 20, 2020

Instead of downloading the file into a temporary file (storage.open
and then .read) to save the file into another temporary file (our
loop reading by chunks) we just use the storage.open response as the
input of the tarfile.open function and extract it from there.

Related to #6793

Instead of downloading the file into a temporary file (`storage.open`
and then `.read`) to save the file into another temporary file (our
loop reading by chunks) we just use the `storage.open` response as the
input of the `tarfile.open` function and extract it from there.
stsewd
stsewd approved these changes Mar 23, 2020
@humitos
Copy link
Member Author

@humitos humitos commented Mar 23, 2020

Merging. Failing tests are unrelated to this PR (master seems broken as well)

@humitos humitos merged commit 24ca737 into master Mar 23, 2020
2 of 3 checks passed
@humitos humitos deleted the humitos/use-storage-properly-tar branch Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants