Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "Uploading" build state when uploading artifacts into storage #6810

Merged

Conversation

humitos
Copy link
Member

@humitos humitos commented Mar 24, 2020

Now, it will show "Uploading" before start performing the upload of build artifacts to the storage.

NOTE: this PR is branched off of #6800. So, we will want to merge this one there or change base to master once the other one is merged.

This PR is missing the migration that will just add a new choice in the field.

@@ -18,6 +19,7 @@
(BUILD_STATE_CLONING, _('Cloning')),
(BUILD_STATE_INSTALLING, _('Installing')),
(BUILD_STATE_BUILDING, _('Building')),
(BUILD_STATE_UPLOADING, _('Uploading')),
Copy link
Member

@ericholscher ericholscher Mar 24, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect this to need a migration. Curious that it isn't failing.

Copy link
Member

@ericholscher ericholscher left a comment

This makes sense to me 👍

@ericholscher ericholscher merged commit 37c0781 into humitos/pulling-cache-status Mar 24, 2020
1 of 2 checks passed
@ericholscher ericholscher deleted the humitos/uploading-build-state branch Mar 24, 2020
@ericholscher
Copy link
Member

@ericholscher ericholscher commented Mar 24, 2020

Hrm, this wasn't into master I see. Not sure the best action there.

@humitos humitos mentioned this pull request Mar 24, 2020
@humitos
Copy link
Member Author

@humitos humitos commented Mar 24, 2020

@ericholscher see #6816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants