Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report build status in a smarter way #6839

Merged
merged 1 commit into from Mar 31, 2020
Merged

Conversation

humitos
Copy link
Member

@humitos humitos commented Mar 31, 2020

It could happen that the person that has imported the project does not
have permissions anymore to send Build Status to the social
service (e.g. GitHub).

In that case, we were just skipping the report to the service
completely.

On the other hand, if the project didn't have a RemoreRepository, we
were trying using all the mantainers' accounts to report the status.

This commit uses the same re-trying code, but also when the first
attempt using the account of the user that imported the repository,
failed.

Closes #6686

It could happen that the person that has imported the project does not
have permissions anymore to send Build Status to the social
service (e.g. GitHub).

In that case, we were just skipping the report to the service
completely.

On the other hand, if the project didn't have a RemoreRepository, we
were trying using all the mantainers' accounts to report the status.

This commit uses the same re-trying code, but also when the first
attempt using the account of the user that imported the repository,
failed.
@humitos humitos requested a review from Mar 31, 2020
Copy link
Member

@ericholscher ericholscher left a comment

Makes sense -- we should likely have this same logic around webhook syncing and all the other actions we do as well.

@humitos humitos merged commit 6517ecf into master Mar 31, 2020
2 checks passed
@humitos humitos deleted the humitos/build-status-report branch Mar 31, 2020
@jack1142
Copy link

jack1142 commented Mar 31, 2020

Hi, where will this be deployed? RTD project I maintain has be affected by this and I was wondering when we will be able to test out if status checks get reported.

@stsewd
Copy link
Member

stsewd commented Mar 31, 2020

@jack1142 hopefully today in a couple of hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants