Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove private argument from resolver #6864

Merged
merged 2 commits into from Apr 7, 2020
Merged

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Apr 6, 2020

This isn't used in any part of the code or to change the behavior from the resolver (checked in .com too) and is using an extra query

Related to #6455

This isn't used in any part of the code and is using an extra query
@stsewd stsewd requested a review from Apr 6, 2020
Copy link
Member

@ericholscher ericholscher left a comment

Makes sense. This was used historically in a few places, but looking at the commit log, they have all been removed.

stsewd added a commit that referenced this issue Apr 7, 2020
This together with:
- #6867
- #6865
- #6864

reduces a lot of queries and without changing the current UI.

This is a benchmark using the django debug toolbar:

Before: 138 queries with 7 subprojects, 17 queries per each additional subproject

With all the changes: 28 queries with 7 subprojects, 1 query per each additional subproject
@ericholscher ericholscher merged commit 675b1a0 into master Apr 7, 2020
2 checks passed
@ericholscher ericholscher deleted the remove-private-resolver branch Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants