Don't do extra query if the project is a translation #6865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only check for superprojects if the project isn't a translation. This reduces a query
|
Failure on travis is unrelated |
ericholscher
approved these changes
Apr 6, 2020
readthedocs/core/resolver.py
Outdated
| else: | ||
| projects.append(project) | ||
| projects = projects or set() | ||
| projects.add(project) |
There was a problem hiding this comment.
Why is this logic changed? It feels less clear to me.
stsewd
added a commit
that referenced
this pull request
Apr 7, 2020
This together with: - #6867 - #6865 - #6864 reduces a lot of queries and without changing the current UI. This is a benchmark using the django debug toolbar: Before: 138 queries with 7 subprojects, 17 queries per each additional subproject With all the changes: 28 queries with 7 subprojects, 1 query per each additional subproject
|
Failure is unrelated edit: travis is working again 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only check for superprojects if the project isn't a translation.
This reduces a query
Ref #6455