Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the status name in CI configurable via setting #6877

Merged
merged 2 commits into from Apr 8, 2020

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Apr 7, 2020

We had the same one on .org/.com and it was overwriting each other.

We had the same one on .org/.com and it was overwriting each other.
@ericholscher ericholscher requested a review from Apr 7, 2020
stsewd
stsewd approved these changes Apr 7, 2020
Copy link
Member

@stsewd stsewd left a comment

This can be removed from the constants now

RTD_BUILD_STATUS_API_NAME = 'continuous-documentation/read-the-docs'

@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Apr 7, 2020

Ah yea, I had that locally but didn't push it up 👍

humitos
humitos approved these changes Apr 8, 2020
@ericholscher ericholscher merged commit 5759379 into master Apr 8, 2020
2 checks passed
@ericholscher ericholscher deleted the configurable-status-name branch Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants