Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements #6885

Merged
merged 4 commits into from Apr 9, 2020
Merged

Update requirements #6885

merged 4 commits into from Apr 9, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Apr 9, 2020

This is a subset from #6866

There aren't breaking changes.

This is a subset from #6866

There aren't breaking changes.
mkdocs==1.0.4
Markdown==3.1.1
mkdocs==1.1
Markdown==3.2.1
Copy link
Member Author

@stsewd stsewd Apr 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we really need mkdocs here, since we use sphinx 🤷‍♂️

@stsewd stsewd requested a review from Apr 9, 2020
humitos
humitos approved these changes Apr 9, 2020
Copy link
Member

@humitos humitos left a comment

Looks good to me! None of them are super critical, so I don't think they will introduce problems.

@stsewd
Copy link
Member Author

@stsewd stsewd commented Apr 9, 2020

We have a lot of tests that are creating the models with non-existing attributes, ddf is more strict about that in the new version, couldn't figure out all of them, so I created an issue for that #6886

@stsewd stsewd merged commit 5b605e4 into master Apr 9, 2020
2 checks passed
@stsewd stsewd deleted the update-requirements branch Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants