Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the project slug in the PR context #6904

Merged
merged 1 commit into from Apr 16, 2020
Merged

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Apr 14, 2020

We have cases where the same repo has multiple projects on RTD,
so we can support multiple builds that are happening for the same commit.

This is probably not the best design so we'll want to think more about this,
but I think showing them all for now at least makes sense.

We have cases where the same repo has multiple projects on RTD,
so we can support multiple builds that are happening for the same commit.

This is probably not the best design so we'll want to think more about this,
but I think showing them all for now at least makes sense.
@ericholscher ericholscher requested a review from Apr 14, 2020
Copy link
Contributor

@davidfischer davidfischer left a comment

Based on my reading of the github and gitlab docs, this looks fine.

@ericholscher ericholscher merged commit 4e037f1 into master Apr 16, 2020
2 checks passed
@ericholscher ericholscher deleted the slug-in-pr-context branch Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants