Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hoverxref to our docs #6911

Merged
merged 1 commit into from Apr 16, 2020
Merged

Add hoverxref to our docs #6911

merged 1 commit into from Apr 16, 2020

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Apr 15, 2020

No description provided.

@ericholscher ericholscher requested review from humitos and Apr 15, 2020
Copy link
Member

@humitos humitos left a comment

👍 --there is a problem, though. It will fail when running PDF build. See readthedocs/sphinx-hoverxref#63

I'm working in a solution for that.

tox.ini Outdated Show resolved Hide resolved
@humitos
Copy link
Member

@humitos humitos commented Apr 16, 2020

Now that the PR where merged in master, this build should just work.

@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Apr 16, 2020

Rebased & pushed it up.

@ericholscher ericholscher merged commit f29732f into master Apr 16, 2020
1 of 2 checks passed
@ericholscher
Copy link
Member Author

@ericholscher ericholscher commented Apr 16, 2020

🎉

@ericholscher ericholscher deleted the add-hoverxref branch Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants