Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the dashboard search to default to searching files #6920

Merged
merged 3 commits into from Apr 27, 2020

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Apr 17, 2020

A project search for the .com use-case only returns projects already in the dashboard,
so it makes little sense there.
This changes it so that the search bar actually searches files first,
which is almost certainly what people want most of the time.

We could also consider changing the default search on the frontpage of the .org to search files,
but I'm not quite sure that is as important.

A project search for the .com use-case only returns projects already in the dashboard.
This changes it so that the search bar actually searches files first,
which is almost certainly what people want most of the time.
@ericholscher ericholscher requested a review from Apr 17, 2020
@ericholscher ericholscher requested a review from agjohnson Apr 17, 2020
stsewd
stsewd approved these changes Apr 20, 2020
Copy link
Member

@stsewd stsewd left a comment

I'm +1 on this. Only linter is failling

readthedocs/projects/views/private.py Show resolved Hide resolved
Co-Authored-By: Santos Gallegos <santos_g@outlook.com>
@ericholscher ericholscher merged commit 5b04364 into master Apr 27, 2020
2 checks passed
@ericholscher ericholscher deleted the search-files-default branch Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants