Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove note about underscore in domain #6924



Copy link

@davidfischer davidfischer commented Apr 17, 2020

I think this note distracts more than it helps. There are 7 projects on .org with a _ in the slug and 4 on .com. Most of these are our projects as well. It isn't possible to create a new project with an underscore.

@davidfischer davidfischer requested a review from Apr 17, 2020
Copy link

@ericholscher ericholscher left a comment

Yea, I'm fine removing this 👍

@ericholscher ericholscher merged commit e839813 into master Apr 17, 2020
2 checks passed
@ericholscher ericholscher deleted the davidfischer/custom-domains-remove-underscore-note branch Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants