Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Per-project concurrency and check before triggering the build #6927

Merged
merged 3 commits into from Apr 20, 2020

Conversation

humitos
Copy link
Member

@humitos humitos commented Apr 18, 2020

Before triggering the build, we check for the concurrency limits (per-project
and globally) and if the limit is reached, we add the error message immediately
to the build. This way, we communicate this at trigger time instead when the
build is executed.

Besides, this commit adds a new field on Project model (max_concurrent_builds)
to be able to override this number by project if needed.

Continuation of #6847

Before triggering the build, we check for the concurrency limits (per-project
and globally) and if the limit is reached, we add the error message immediately
to the build. This way, we communicate this at trigger time instead when the
build is executed.

Besides, this commit adds a new field on Project model (`max_concurrent_builds`)
to be able to override this number by project if needed.
@humitos humitos requested review from ericholscher and Apr 18, 2020
Copy link
Member

@ericholscher ericholscher left a comment

This is a good change 👍

@humitos humitos merged commit 52a7ccd into master Apr 20, 2020
2 checks passed
@humitos humitos deleted the humitos/ux-concurrent-builds branch Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants