Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not override the domain of Azure Storage #6928

Merged
merged 1 commit into from Apr 20, 2020

Conversation

humitos
Copy link
Member

@humitos humitos commented Apr 18, 2020

Now we are not proxying the Storage request via NGINX anymore, all the internal
communication between containers should be done using the containers
host (e.g. storage:10000).

This is required for example by the Embed API that hits the storage from the web
container, which does not work anymore hitting community.dev.readthedocs.io
since we removed the NGINX proxy rule.

Now we are not proxying the Storage request via NGINX anymore, all the internal
communication between containers should be done using the containers
host (e.g. `storage:10000`).

This is required for example by the Embed API that hits the storage from the web
container, which does not work anymore hitting `community.dev.readthedocs.io`
since we removed the NGINX proxy rule.
@humitos humitos requested review from ericholscher and a team and removed request for ericholscher Apr 18, 2020
@humitos humitos merged commit a2a6135 into master Apr 20, 2020
2 checks passed
@humitos humitos deleted the humitos/no-override-domain-storage branch Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants