Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass the NO_COLOR env var to builder #6981

Merged
merged 2 commits into from May 27, 2020
Merged

Pass the NO_COLOR env var to builder #6981

merged 2 commits into from May 27, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Apr 28, 2020

We should let tools know that we don't want ANSI escaped colors in
the output.

Closes #6883

We should let tools know that we don't want ANSI escaped colors in
the output.

Closes #6883
@stsewd stsewd requested a review from Apr 28, 2020
@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Apr 29, 2020

Alternatively, I'd love to have ansi control characters in the output that we could use to colorize the output. I'm not sure the best way to consome these, but it would be a huge UI win.

@agjohnson
Copy link
Contributor

@agjohnson agjohnson commented Apr 29, 2020

I have a working implementation of ansi control character colorizing output, and i'm tracking revert of this PR. This PR can continue until we're closer on the template project.

@stsewd stsewd merged commit b6650e6 into master May 27, 2020
2 checks passed
@stsewd stsewd deleted the pass-no-color branch May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants