Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start storing JSON data for PR builds #7001

Merged
merged 1 commit into from Apr 30, 2020
Merged

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented Apr 29, 2020

This will let us do a couple things:

  • Make the embed API work in PR previews
  • Allow us to start indexing search for PRs once we want that feature-set

This will let us do a couple things:

* Make the embed API work in PR previews
* Allow us to start indexing search for PRs once we want that feature-set
@ericholscher ericholscher requested a review from humitos Apr 29, 2020
stsewd
stsewd approved these changes Apr 29, 2020
Copy link
Member

@stsewd stsewd left a comment

I wanted to have search for PRs!

@ericholscher
Copy link
Member Author

ericholscher commented Apr 29, 2020

@stsewd this doesn't index search in PR's yet. We need a way to make it operationally less overhead. I'm thinking a totally different search index for PR's, so that they shouldn't effect normal prod search.

Copy link
Member

@humitos humitos left a comment

Makes sense to me!

@ericholscher ericholscher merged commit 1802e15 into master Apr 30, 2020
2 checks passed
@ericholscher ericholscher deleted the store-json-pr-builds branch Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants