Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxito headers to redirect responses #7007

Merged
merged 7 commits into from May 5, 2020

Conversation

ericholscher
Copy link
Member

@ericholscher ericholscher commented May 1, 2020

This lets us set the cache and debug headers on all our proxito responses.
This is a step towards letting us cache pages a longer amount of time.

This includes and fixes #6907 as well 馃憤

This lets us set the cache and debug headers on all our proxito responses.
This is a step towards letting us cache pages a longer amount of time.
@ericholscher ericholscher requested a review from a team May 1, 2020 13:59
@ericholscher ericholscher requested a review from humitos May 1, 2020 14:09
@davidfischer
Copy link
Contributor

This looks like a cleaner solution!

@@ -144,6 +145,8 @@ def process_response(self, request, response): # noqa

hsts_header_values = []

self.add_proxito_headers(request, response)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than adding a single-use mixin in a separate file, couldn't this method just be a method on this class?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I thought we'd have to use it more places, but we haven't yet, so that seems fine. 馃憤

@ericholscher ericholscher merged commit a75907c into master May 5, 2020
1 check passed
@ericholscher ericholscher deleted the expand-proxito-headers branch May 5, 2020 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants