Add proxito headers to redirect responses #7007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets us set the cache and debug headers on all our proxito responses. This is a step towards letting us cache pages a longer amount of time.
|
This looks like a cleaner solution! |
davidfischer
approved these changes
May 5, 2020
| @@ -144,6 +145,8 @@ def process_response(self, request, response): # noqa | |||
|
|
|||
| hsts_header_values = [] | |||
|
|
|||
| self.add_proxito_headers(request, response) | |||
There was a problem hiding this comment.
Rather than adding a single-use mixin in a separate file, couldn't this method just be a method on this class?
There was a problem hiding this comment.
Yea, I thought we'd have to use it more places, but we haven't yet, so that seems fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This lets us set the cache and debug headers on all our proxito responses.
This is a step towards letting us cache pages a longer amount of time.
This includes and fixes #6907 as well👍