Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mkdocs: Index pages without anchors #7024

Merged
merged 3 commits into from May 11, 2020
Merged

Mkdocs: Index pages without anchors #7024

merged 3 commits into from May 11, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented May 5, 2020

Turns out the pages without a fragment need be indexed as well.
This looks like duplicated content, but it's actually different.
And the normal mkdocs search shows the two as well.

This makes more sense when the page doesn't have any fragment (page without a title)

Screenshot_2020-05-05 Read the Docs MkDocs Test

Turns out the pages without a fragment need be indexed as well.
This looks like duplicated content, but it's actually different.
And the normal mkdocs search shows the two as well.
@stsewd stsewd requested a review from May 5, 2020
Copy link
Member

@ericholscher ericholscher left a comment

I think this is good to ship, but a bit more clarity in the code for later when we're confused by this will be good :)

readthedocs/search/parse_json.py Show resolved Hide resolved
@stsewd stsewd merged commit 6144708 into master May 11, 2020
2 checks passed
@stsewd stsewd deleted the index-pages-without-fragments branch May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants