Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement repo_exists for all VCS backends #7025

Merged
merged 1 commit into from May 5, 2020
Merged

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented May 5, 2020

No description provided.

version_repo.supports_lsremote and
not version_repo.repo_exists() and
self.project.has_feature(Feature.VCS_REMOTE_LISTING)
Copy link
Member Author

@stsewd stsewd May 5, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to short-circuit here, so we only execute the command if supports_lsremote is true.

Copy link
Member

@ericholscher ericholscher left a comment

Makes sense once tests pass 👍

@ericholscher ericholscher merged commit 47286d7 into master May 5, 2020
2 checks passed
@ericholscher ericholscher deleted the implement-repo-exists branch May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants