Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide unbuilt versions in footer flyout #7056

Merged
merged 2 commits into from May 14, 2020

Conversation

santos22
Copy link
Contributor

@santos22 santos22 commented May 11, 2020

Should fix #6971

This also assumes the latest version has built=True, which I'm not sure is the case in production.

@santos22
Copy link
Contributor Author

santos22 commented May 13, 2020

The following might need to be updated in test_version_queries to include built=True:

self.pip.versions.create(
    verbose_name=identifier,
    identifier=identifier,
    type=TAG,
    active=True,
    built=True,
)

@stsewd
Copy link
Member

stsewd commented May 13, 2020

@santos22 yeah, is fine to update those tests.

@santos22
Copy link
Contributor Author

santos22 commented May 13, 2020

Updated the test 👍

@santos22
Copy link
Contributor Author

santos22 commented May 13, 2020

There was a line that was too long - is the following okay for the lint check?

def public(self, user=None, project=None, only_active=True,
           include_hidden=True, only_built=False):

@stsewd
Copy link
Member

stsewd commented May 13, 2020

@santos22 yeah, that works

stsewd
stsewd approved these changes May 14, 2020
Copy link
Member

@stsewd stsewd left a comment

LGTM!, thanks!

@stsewd stsewd requested a review from a team May 14, 2020
@ericholscher ericholscher merged commit 119fe54 into readthedocs:master May 14, 2020
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants