Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: track total results #7080

Merged
merged 3 commits into from May 14, 2020
Merged

Search: track total results #7080

merged 3 commits into from May 14, 2020

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented May 14, 2020

Closes #7047

# TODO: to avoid downtime, remove later.
null=True,
Copy link
Member Author

@stsewd stsewd May 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's ok to not save some search queries during deploy I can just remove this.

@stsewd stsewd requested a review from ericholscher May 14, 2020
Copy link
Member

@ericholscher ericholscher left a comment

Looks good with an addition to add the results to the user-facing display.

readthedocs/projects/views/private.py Show resolved Hide resolved
@stsewd
Copy link
Member Author

@stsewd stsewd commented May 14, 2020

@ericholscher are we ok showing 0 results for old queries? Looks like integerfield treats None as 0, so I can't check for None for the old queries.

Screenshot_2020-05-14 Search Analytics Read the Docs

@ericholscher
Copy link
Member

@ericholscher ericholscher commented May 14, 2020

@stsewd yea I think thats fine for now. It will slowly fill in.

@stsewd stsewd merged commit 7bd678e into master May 14, 2020
2 checks passed
@stsewd stsewd deleted the track-total-results branch May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants